aokolnychyi commented on a change in pull request #3256:
URL: https://github.com/apache/iceberg/pull/3256#discussion_r730071369
##########
File path: jmh.gradle
##########
@@ -17,15 +17,22 @@
* under the License.
*/
-def jmhProjects = []
-if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
- jmhProjects = [ project("iceberg-spark2"), project("iceberg-spark3") ]
-} else if (JavaVersion.current() == JavaVersion.VERSION_11) {
- jmhProjects = [ project("iceberg-spark3") ]
-} else {
+if (jdkVersion != '8' && jdkVersion != '11') {
throw new GradleException("The JMH benchamrks must be run with JDK 8 or JDK
11")
}
+def knownSparkVersions = System.getProperty("knownSparkVersions").split(",")
Review comment:
Do we use `knownSparkVersions` in jmh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
