openinx commented on a change in pull request #3250:
URL: https://github.com/apache/iceberg/pull/3250#discussion_r730535657
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/SparkFileWriterFactory.java
##########
@@ -110,6 +110,17 @@ protected void configureDataWrite(ORC.DataWriteBuilder
builder) {
builder.createWriterFunc(SparkOrcWriter::new);
}
+ @Override
+ protected void configureEqualityDelete(ORC.DeleteWriteBuilder builder) {
+ builder.createWriterFunc((iSchema, typDesc) -> new SparkOrcWriter(iSchema,
typDesc));
Review comment:
Nit: The lambda can be replaced with a method reference:
`SparkOrcWriter::new` I think.
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/SparkFileWriterFactory.java
##########
@@ -110,6 +110,17 @@ protected void configureDataWrite(ORC.DataWriteBuilder
builder) {
builder.createWriterFunc(SparkOrcWriter::new);
}
+ @Override
+ protected void configureEqualityDelete(ORC.DeleteWriteBuilder builder) {
+ builder.createWriterFunc((iSchema, typDesc) -> new SparkOrcWriter(iSchema,
typDesc));
+ }
+
+ @Override
+ protected void configurePositionDelete(ORC.DeleteWriteBuilder builder) {
+ builder.createWriterFunc((iSchema, typDesc) -> new SparkOrcWriter(iSchema,
typDesc));
Review comment:
Nit: ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
