pvary commented on a change in pull request #3242:
URL: https://github.com/apache/iceberg/pull/3242#discussion_r730761741
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java
##########
@@ -100,19 +103,36 @@
.toArray(InputSplit[]::new);
}
+ protected void checkHive3Present() {
Review comment:
Could we add `VisibleForTesting` annotation here (from the relocated
packaged)
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java
##########
@@ -100,19 +103,36 @@
.toArray(InputSplit[]::new);
}
+ protected void checkHive3Present() {
+ Preconditions.checkArgument(HIVE_3_PRESENT_ON_CLASSPATH, "Vectorization
only supported for Hive 3+");
+ }
+
+ // Need for testing
+ protected RecordReader<Void, Container<Record>>
getVectorizedRecordReader(IcebergSplit icebergSplit,
Review comment:
Could we add `VisibleForTesting` annotation here (from the relocated
packaged)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
