nssalian commented on pull request #3275: URL: https://github.com/apache/iceberg/pull/3275#issuecomment-946025275
Thanks for the comments @rdblue . re: namespace and table I would prefer the scricter approach since it has the check in place to ensure a table is created only if a namespace exists. A config can be added for legacy reasons but that will mean a dual behavior for the NamespaceExists logic - one with the config and one without. If that breaking change is ok with the community and can be rolled out, I think I can amend the PR to have that implementation. The only implementation issue I see here is we need to add the properties that the Catalog is initialized with to get connection properties within the JdbcTableOperations class. I have this in the larger PR https://github.com/apache/iceberg/pull/3274 by adding a dbProperties field. re: table schema I agree and I think that makes more sense. A namespace_properties table could hold the properties with a single row representing a property per namespace. I see this akin to the Hive Metastore. We just have to do some stitching of the properties when retrieving for a single namespace. Removal will be easier in this model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
