flyrain commented on a change in pull request #3287:
URL: https://github.com/apache/iceberg/pull/3287#discussion_r731354494
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -183,6 +189,18 @@ protected boolean shouldKeep(T item) {
return remainingRowsFilter.filter(records);
}
+ public Set<Long> posDeletedRowIds() {
Review comment:
The https://github.com/RoaringBitmap/RoaringBitmap is used in the new
commit, which can support index to be a 64-bit integer(long) and is more memory
efficient than Java's BitSet. It is used by Spark as well as bunch of other ASF
projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
