zhangminglei commented on a change in pull request #3186:
URL: https://github.com/apache/iceberg/pull/3186#discussion_r731441502
##########
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestPartitionValues.java
##########
@@ -418,17 +418,19 @@ public void testPartitionedByNestedString() throws
Exception {
// write into iceberg
sourceDF.write()
- .format("iceberg")
- .mode(SaveMode.Append)
- .save(baseLocation);
+ .format("iceberg")
+ .option(WRITE_FORMAT, format)
+ .mode(SaveMode.Append)
+ .save(baseLocation);
// verify
List<Row> actual = spark.read()
- .format("iceberg")
- .option(SparkReadOptions.VECTORIZATION_ENABLED,
String.valueOf(vectorized))
- .load(baseLocation)
- .collectAsList();
+ .format("iceberg")
+ .option(SparkReadOptions.VECTORIZATION_ENABLED,
String.valueOf(vectorized))
+ .load(baseLocation)
+ .collectAsList();
Review comment:
Thank you for review this and I've revert that code. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
