kbendick commented on a change in pull request #3311: URL: https://github.com/apache/iceberg/pull/3311#discussion_r731467337
########## File path: hive-runtime/build.gradle ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +def hiveVersions = (System.getProperty("hiveVersions") != null ? System.getProperty("hiveVersions") : System.getProperty("defaultHiveVersions")).split(",") Review comment: Should these be documented? It's `{"2", "3"}`, correct? I don't see where the `defaultHiveVersions` is set or defined at all but I could see users trying "3.3" or even hadoop related numbers from their Spark dependency as it's in the downloadable name. ########## File path: hive-runtime/build.gradle ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +def hiveVersions = (System.getProperty("hiveVersions") != null ? System.getProperty("hiveVersions") : System.getProperty("defaultHiveVersions")).split(",") + +project(':iceberg-hive-runtime') { + apply plugin: 'com.github.johnrengelman.shadow' + + tasks.jar.dependsOn tasks.shadowJar + + configurations { + implementation { + exclude group: 'com.github.stephenc.findbugs' + exclude group: 'commons-pool' + exclude group: 'javax.annotation' + exclude group: 'javax.xml.bind' + exclude group: 'org.apache.commons' + exclude group: 'org.slf4j' + exclude group: 'org.xerial.snappy' + } + } + + dependencies { + implementation project(':iceberg-mr') + if (jdkVersion == '8' && hiveVersions.contains("3")) { + implementation project(':iceberg-hive3') + } + implementation(project(':iceberg-nessie')) { + exclude group: 'com.google.code.findbugs', module: 'jsr305' + } + implementation project(':iceberg-aws') Review comment: Should we eventually allow for opt-in of jars that users don't necessarily require (goes for all of them) or does that mess with code compilation? I assume the latter but my gradle is a bit limited. If this is just copy pasted, it might make sense to deal with any of that as a follow up task (if at all). And might not even be worth pursuing given that we shade so we can't conflict. ########## File path: hive-runtime/build.gradle ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +def hiveVersions = (System.getProperty("hiveVersions") != null ? System.getProperty("hiveVersions") : System.getProperty("defaultHiveVersions")).split(",") + +project(':iceberg-hive-runtime') { Review comment: The proposed hive3-orc-bundle file has a top level comment about enabling Hive 3 specific features. Does this build file (which is used for both hive2 and hive3) also merit some sort of comment? The way its cleaned up now doesn't require nearly as much explanation, but I was confused by the additional dependency at first (but could also just be the order of ingestion). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
