kbendick commented on pull request #3304: URL: https://github.com/apache/iceberg/pull/3304#issuecomment-946416898
Can we possibly make it a separate action entirely? Some of them can take quite a while to run. We might want to just follow up on those issues if they become problems. Im not a huge fan of running these tests via CI as I'm just admittedly not a huge fan of JMH tests. But I think this is good enough for now. Perhaps you can look for an existing JMH workflow or some pattern to help form groupings or easily allow us to. +1 overall from me if we feel like having this. But I do see the utility. On Mon, Oct 18, 2021 at 11:38 PM Eduard Tudenhöfner < ***@***.***> wrote: > That seems like a lot tags to add for benchmarks. We would probably need > to keep those up to date, and it would clutter the PR list. > > Is it possible to either reduce the number of tags to groups, like > arrow-benchmarks and spark-benchmarks, or to change this to run benchmarks > when specific files change instead? It seems like those would be easier > ways to configure this. I'm a fan of using Github actions, though! > > I agree that the number of tags required are quite long and have to be > kept in sync with new benchmarks being added. However, I was thinking that > this might be acceptable for the beginning until we know that all > benchmarks are actually stable enough to run on GH actions. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/3304#issuecomment-946409702>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACLAXEXABFUCVMY43IKARE3UHUG45ANCNFSM5GGPEBIQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
