jacques-n commented on pull request #3188: URL: https://github.com/apache/iceberg/pull/3188#issuecomment-947249330
@rdblue , I think your comments are mostly focused on table identifiers. I'll respond to those below. Field names are probably the more important of the two. We should specify clearly what it means for a view to be "invalid". For example, if the SQL parses but the column names or column types are different, I would expect this to fail with an invalid view definition error. Additionally, I think we should probably cleanup the weird dual column definition pattern (if a user expressed column name aliases in the create view versus the population of derived * column names in the schema). Also, if we're capturing what the user wrote, we should probably capture the CREATE VIEW ... part of the command (not just the inner sql). I think this is consistent with how other tools expose the data. WRT to table identifiers, I struggle with being opinionated about resolution given that end users may work in a system that already has a particular resolution behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
