velctor commented on a change in pull request #3276:
URL: https://github.com/apache/iceberg/pull/3276#discussion_r732478544



##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java
##########
@@ -178,7 +180,8 @@ public long getLength() throws IOException {
 
     @Override
     public SeekableInputStream newStream() throws IOException {
-      return stream(file.newStream());
+      icebergHadoopStream = file.newStream();
+      return stream(icebergHadoopStream);

Review comment:
       I know that, but `InputFile` object is the  member variable of 
`org.apache.parquet.hadoop.ParquetFileReader$ParquetFileReader` and the 
`org.apache.iceberg.io.SeekableStream` object will be GC after `this.f = 
file.newStream();` . 
   I think this may be an easier way to solve this problem, under the premise 
of keeping https://github.com/apache/iceberg/pull/90.  I want to know if you 
have any other ideas.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to