rdblue commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r733077010
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -199,7 +182,7 @@ public TableScan ignoreResiduals() {
Snapshot snapshot = snapshot();
if (snapshot != null) {
LOG.info("Scanning table {} snapshot {} created at {} with filter {}",
table,
- snapshot.snapshotId(),
formatTimestampMillis(snapshot.timestampMillis()),
+ snapshot.snapshotId(),
SnapshotUtil.formatTimestampMillis(snapshot.timestampMillis()),
Review comment:
`formatTimeStampMillis` doesn't really fit into `SnapshotUtil`. If you
want to make it private, it's okay to be there. If you want to share it here
and in that util class, then it should live somewhere else. Maybe
`DateTimeUtil`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
