kbendick commented on a change in pull request #3332:
URL: https://github.com/apache/iceberg/pull/3332#discussion_r733178415
##########
File path:
spark/v3.0/spark3-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java
##########
@@ -735,4 +782,35 @@ private void createPartitionedHiveTable() {
partitionedDF.write().insertInto(sourceTableName);
partitionedDF.write().insertInto(sourceTableName);
}
+
+ public List<Record> createOrcFile(File orcFile, int numRows) throws
IOException {
+ // Needs to be deleted but depend on the rule to delete the file for us
again at the end.
+ if (orcFile.exists()) {
+ orcFile.delete();
+ }
+ final org.apache.iceberg.Schema icebergSchema = new
org.apache.iceberg.Schema(
Review comment:
Unfortunately there's no ability to write to ORC with a dataframe from
this test area. I had wanted to do that as well, but it doesn't seem to be
possible (even after the changes that I added).
I agree about not writing with the IDs already. Let me see if there's
another way to write out the file. I was trying a few ways but now that I added
the imports, those other ways might work. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
