aokolnychyi commented on a change in pull request #3287:
URL: https://github.com/apache/iceberg/pull/3287#discussion_r733193427
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -185,6 +192,18 @@ protected boolean shouldKeep(T item) {
return remainingRowsFilter.filter(records);
}
+ public Roaring64Bitmap posDeletedRowIds() {
+ if (posDeletes.isEmpty()) {
+ return null;
+ }
+
+ if (posDeleteRowIds == null) {
+ List<CloseableIterable<Record>> deletes = Lists.transform(posDeletes,
this::openPosDeletes);
+ posDeleteRowIds = Deletes.toPositionBitMap(dataFile.path(),
CloseableIterable.concat(deletes));
Review comment:
Shall this use the overload method in `Deletes` that accepts
`List<CloseableIterable<T>>`?
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -185,6 +192,18 @@ protected boolean shouldKeep(T item) {
return remainingRowsFilter.filter(records);
}
+ public Roaring64Bitmap posDeletedRowIds() {
+ if (posDeletes.isEmpty()) {
+ return null;
+ }
+
+ if (posDeleteRowIds == null) {
+ List<CloseableIterable<Record>> deletes = Lists.transform(posDeletes,
this::openPosDeletes);
+ posDeleteRowIds = Deletes.toPositionBitMap(dataFile.path(),
CloseableIterable.concat(deletes));
Review comment:
Shall this use the overloaded method in `Deletes` that accepts
`List<CloseableIterable<T>>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
