nastra commented on a change in pull request #3029:
URL: https://github.com/apache/iceberg/pull/3029#discussion_r733393852
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -150,7 +150,7 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
vectorizedColumnIterator.varWidthTypeBatchReader().nextBatch(vec,
-1, nullabilityHolder);
break;
case FIXED_WIDTH_BINARY:
-
vectorizedColumnIterator.fixedWidthTypeBinaryBatchReader().nextBatch(vec,
typeWidth, nullabilityHolder);
Review comment:
`FIXED_WIDTH_BINARY` might have been misleading so I renamed it to
`FIXED_SIZE_BINARY`. It seems that the `FixedWidthBinary` code path existed as
a workaround for Spark as can be seen
[here](https://github.com/apache/iceberg/blob/master/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedPageIterator.java#L365-L383).
I checked `TestParquetVectorizedReads` and that seems to be testing the
`FIXED` type with Spark+Vectorization
https://github.com/apache/iceberg/blob/f3e6770c0506a13c067f506dad266d043819d446/spark/v3.0/spark3/src/test/java/org/apache/iceberg/spark/data/AvroDataTest.java#L60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
