harshm-dev commented on a change in pull request #3326:
URL: https://github.com/apache/iceberg/pull/3326#discussion_r733467400
##########
File path: site/docs/spark-configuration.md
##########
@@ -54,7 +54,7 @@ Both catalogs are configured using properties nested under
the catalog name. Com
| Property | Values
| Description |
| -------------------------------------------------- |
----------------------------- |
-------------------------------------------------------------------- |
-| spark.sql.catalog._catalog-name_.type | `hive` or `hadoop`
| The underlying Iceberg catalog implementation, `HiveCatalog`,
`HadoopCatalog` or left unset if using a custom catalog |
+| spark.sql.catalog._catalog-name_.type | `hive`, `hadoop`,
`nessie`, `jdbc`, `glue` or `dynamodb`| Represents the underlying Iceberg
catalog implementation. For example - `HiveCatalog` for `hive` and
`HadoopCatalog` for `hadoop`.<br>Leave unset if using a custom catalog via the
conf `catalog-impl`. |
Review comment:
It's an important instruction (Leave unset..) and I felt that a line
break would increase readability.
Is there a place, where I can check the do's and don'ts for doc changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
