pvary commented on a change in pull request #3337:
URL: https://github.com/apache/iceberg/pull/3337#discussion_r733682172
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -499,11 +499,21 @@ private void unlock(Optional<Long> lockId) {
}
@VisibleForTesting
- void doUnlock(long lockId) throws TException, InterruptedException {
- metaClients.run(client -> {
- client.unlock(lockId);
- return null;
- });
+ void doUnlock(long lockId) throws TException {
+ boolean released = false;
+ while (!released) {
+ try {
+ released = metaClients.run(client -> {
Review comment:
What happens if the exception is `No lock found`. This loop will be an
infinite loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
