pvary commented on pull request #3338: URL: https://github.com/apache/iceberg/pull/3338#issuecomment-948882251
> Did you mean that this patch _will_ break hive queries if not catalog is set after it's applied, or does it fix hive queries breaking if no catalog is set? @kbendick: My bad 😄 Ported #2565 to Hive, and the query tests started to break. In those tests we were not setting any catalogs, and the `getCatalog` returned a `HiveCatalog` but the `Catalogs.hiveCatalog` returned false. This is wrong, and also broke the tests, which started to fail when creating a table with `Table location not set` errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
