flyrain commented on a change in pull request #3287:
URL: https://github.com/apache/iceberg/pull/3287#discussion_r733973335
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -185,6 +192,18 @@ protected boolean shouldKeep(T item) {
return remainingRowsFilter.filter(records);
}
+ public Roaring64Bitmap posDeletedRowIds() {
+ if (posDeletes.isEmpty()) {
+ return null;
+ }
+
+ if (posDeleteRowIds == null) {
+ List<CloseableIterable<Record>> deletes = Lists.transform(posDeletes,
this::openPosDeletes);
+ posDeleteRowIds = Deletes.toPositionBitMap(dataFile.path(),
CloseableIterable.concat(deletes));
Review comment:
I think we don't need this method
```
public static Roaring64Bitmap toPositionBitmap(CharSequence dataLocation,
CloseableIterable<? extends
StructLike> deleteFile) {
return toPositionBitmap(dataLocation, ImmutableList.of(deleteFile));
}
```
We can call `toPositionBitmap(CharSequence
dataLocation,List<CloseableIterable<T>> deleteFiles)` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
