rdblue commented on a change in pull request #3331:
URL: https://github.com/apache/iceberg/pull/3331#discussion_r734110047
##########
File path:
api/src/main/java/org/apache/iceberg/transforms/PartitionSpecVisitor.java
##########
@@ -99,25 +99,10 @@ default T unknown(int fieldId, String sourceName, int
sourceId, String transform
* @return a list of the result produced by visiting each partition field
*/
static <R> List<R> visit(PartitionSpec spec, PartitionSpecVisitor<R>
visitor) {
- return visit(spec.schema(), spec, visitor);
- }
-
- /**
- * Visit the fields of a {@link PartitionSpec}.
- *
- * @param schema a schema for source field lookups
- * @param spec a partition spec to visit
- * @param visitor a partition spec visitor
- * @param <R> return type of the visitor
- * @return a list of the result produced by visiting each partition field
- * @deprecated this will be removed in 0.11.0; use {@link
#visit(PartitionSpec, PartitionSpecVisitor)} instead.
- */
- @Deprecated
- static <R> List<R> visit(Schema schema, PartitionSpec spec,
PartitionSpecVisitor<R> visitor) {
Review comment:
Does this change the implementation of the `visit` method on line 101?
Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
