pvary commented on a change in pull request #3242:
URL: https://github.com/apache/iceberg/pull/3242#discussion_r734788607



##########
File path: 
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java
##########
@@ -100,24 +102,47 @@
                  .toArray(InputSplit[]::new);
   }
 
+  @VisibleForTesting
+  void checkHive3Present() {

Review comment:
       TBH I'm not too comfortable with introducing so many extra methods just 
for testing.
   I will be on PTO for a week and I will try to come up with a better solution 
in the meantime.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to