kbendick commented on pull request #3270: URL: https://github.com/apache/iceberg/pull/3270#issuecomment-950395901
> Per aliyun oss SDK documentation: https://help.aliyun.com/document_detail/32009.html, > jdk9 and its plus version, dependency includes jaxb-api, activation and jaxb-runtime. > This PR to package them into one single bundled JAR Given that these are recommended dependencies for using the aliyun-oss package in general (from what I understand at least), is there a chance that the versions chosen here will conflict with the versions a user chose for other needs in their project (stemming from usage of aliyun or otherwise)? I agree with @rdblue that this seems like a case where a shaded jar with relocation of these packages seems like a good idea. If these packages are needed to make Iceberg run, then their inclusion makes sense. But it doesn’t seem in line with current practices in this repo and elsewhere for the Iceberg dependency to enforce a specific version for other components in the user’s package or to have users implicitly depending on Iceberg for packages that are needed for other parts of their application. Iceberg should really only handle the Iceberg dependencies, and then other commonly used dependencies should be relocated. As an example, that’s why all of Iceberg’s usage of parquet goes through `org.apache.Iceberg.relocated.org.apache.parquet`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
