rdblue commented on a change in pull request #3367: URL: https://github.com/apache/iceberg/pull/3367#discussion_r735967587
########## File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/ProcedureProvider.java ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark.procedures; + +import java.util.Map; +import java.util.function.Supplier; +import org.apache.iceberg.catalog.Namespace; +import org.apache.spark.sql.util.CaseInsensitiveStringMap; + +/** + * Provides a set of procedures to be registered in a {@link org.apache.iceberg.spark.SparkCatalog SparkCatalog} or + * {@link org.apache.iceberg.spark.SparkSessionCatalog SparkSessionCatalog} using the + * {@link Namespace namespace} returned by {@link #getNamespace()}. + * + * <p>Instances of this class are discovered using Java's {@link java.util.ServiceLoader} mechanism. + */ +public interface ProcedureProvider { + /** Name of this {@link ProcedureProvider}. */ + String getName(); Review comment: Can you update this to follow the Iceberg project style? * `get` should not be used in method names (use a more specific verb, or omit it) * Javadoc should be multi-line and should include `@return` * Javadoc with more than one paragraph should use `<p>` on its own line to separate paragraphs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
