flyrain commented on a change in pull request #3370:
URL: https://github.com/apache/iceberg/pull/3370#discussion_r736044758
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
##########
@@ -122,22 +121,6 @@ public HadoopCatalog(Configuration conf, String
warehouseLocation) {
initialize("hadoop", ImmutableMap.of(CatalogProperties.WAREHOUSE_LOCATION,
warehouseLocation));
Review comment:
I think we should keep constructor `HadoopCatalog(Configuration conf,
String warehouseLocation)`, it’s pretty useful. Also I didn't find any
particular reason why it is labeled deprecated in the original PR
https://github.com/apache/iceberg/pull/2323. We can at least provide a method
if we don’t like logic be inside a constructor. Any thought?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
