jackye1995 commented on pull request #3378: URL: https://github.com/apache/iceberg/pull/3378#issuecomment-952220260
Thanks for working on this refactoring! One major question I have is around the current versioning design. I see the entire `0.12.0` directory being created to store the `0.12.0` version of the doc. I wonder if we should do that, historically we have been doing this for javadoc which has led to a lot of code search issues in Intellij. I think a better way we can organize the doc is through the build and release process, so that in every release, checkout the historical release tags to copy the `site` to the correct version directory, and then release the website. I also think the current refactoring also lacks a `latest` version, which displays the latest view of the docs. We should not map `/` to `/0.12.0`, but instead to `/latest` because we might have multiple releases of the website before the next new code version release. From PR perspective, my opinion is that we can separate this to 2 PRs, 1 for style changes which I really like, another one for structural change that might potentially involve many files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
