ajantha-bhat commented on a change in pull request #3257:
URL: https://github.com/apache/iceberg/pull/3257#discussion_r737178694
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -214,22 +224,21 @@ public void renameTable(TableIdentifier from,
TableIdentifier toOriginal) {
throw new AlreadyExistsException("table %s already exists", to.name());
}
- Operations contents = ImmutableOperations.builder()
- .addOperations(
-
ImmutablePut.builder().key(NessieUtil.toKey(to)).contents(existingFromTable).build(),
- ImmutableDelete.builder().key(NessieUtil.toKey(from)).build())
+ CommitMultipleOperationsBuilder op = api.commitMultipleOperations()
.commitMeta(NessieUtil.buildCommitMetadata("iceberg rename table",
catalogOptions))
Review comment:
we have already changed in ,
`NessieTableOperations#buildCommitMessage()` which improves commit message. So,
it made sense to me to change this also in the same PR as it is few lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
