omarsmak commented on a change in pull request #3388:
URL: https://github.com/apache/iceberg/pull/3388#discussion_r737287805
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -218,7 +219,9 @@ public void renameTable(TableIdentifier from,
TableIdentifier toOriginal) {
.addOperations(
ImmutablePut.builder().key(NessieUtil.toKey(to)).contents(existingFromTable).build(),
ImmutableDelete.builder().key(NessieUtil.toKey(from)).build())
- .commitMeta(NessieUtil.buildCommitMetadata("iceberg rename table",
catalogOptions))
+ .commitMeta(NessieUtil.buildCommitMetadata(String.format("iceberg
rename table from '%s' to '%s'",
Review comment:
Do we need to use `String.format` here (as well in the other
occurrences)? Can we just use plain `+`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
