RussellSpitzer commented on pull request #3375: URL: https://github.com/apache/iceberg/pull/3375#issuecomment-953000789
> @jackye1995 , @RussellSpitzer : I have added some more arguments. Also updated the document. As per me only `sort related options` and `where` arguments are pending. For `where` , I am not sure how to convert text to expression yet. For `sort related options` I am not sure whether to have as map or individual options. If ok, I want to handle this in subsequent PR. please review the current changes. > > Also I should copy the same code in spark/v3.2 folder as well ? > > p.s: Also let me know if any other arguments is missed. For "where" can you check and see if you can produce expressions using the Spark session's parser? I think you may be able to convert to expressions using the parser and then translate them using our Spark3 utils ... I'm not sure though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
