hankfanchiu commented on a change in pull request #3379:
URL: https://github.com/apache/iceberg/pull/3379#discussion_r737721924
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -164,6 +167,8 @@ protected HiveTableOperations(Configuration conf,
ClientPool metaClients, FileIO
long tableLevelLockCacheEvictionTimeout =
conf.getLong(HIVE_TABLE_LEVEL_LOCK_EVICT_MS,
HIVE_TABLE_LEVEL_LOCK_EVICT_MS_DEFAULT);
initTableLevelLockCache(tableLevelLockCacheEvictionTimeout);
+ this.metadataRefreshMaxRetries =
conf.getInt(HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES,
+ HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES_DEFAULT);
Review comment:
Should we set `metadataRefreshMaxRetries` after setting
`lockCheckMaxWaitTime`?
https://github.com/apache/iceberg/blob/e09b44a7b3ef7cae5e4876f8eb6b8fb9c84ff400/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L165-L166
Groups them together like their declarations 🤷 :
https://github.com/apache/iceberg/blob/e09b44a7b3ef7cae5e4876f8eb6b8fb9c84ff400/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L148-L149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
