samredai commented on a change in pull request #3382:
URL: https://github.com/apache/iceberg/pull/3382#discussion_r737733642
##########
File path: site/docs/theme_customization/nav-item.html
##########
@@ -0,0 +1,55 @@
+<li
+ class="wm-toc-li wm-toc-lev{{ navlevel }} {% if nav_item.children
%}wm-toc-opener{% endif %}"
+>
+ {%- if nav_item.url or nav_item.is_page or nav_item.is_link or nav_item.url
+ -%}
+ <a href="{{ nav_item.url }}" class="wm-article-link wm-toc-text"
+ >{{ nav_item.title }}</a
+ >
+ {%- else -%}
+
+ <!-- Set a font awesome icon based on the menu item title -->
+ {%- if nav_item.title == "Tables" -%}
+ <span class="wm-toc-text"
+ ><i class="fa fa-table" style="color:#68C2EB"></i> {{ nav_item.title
}}</span
Review comment:
Changed the icons to fixed width (looks much much better!).
I also removed the color from the icons by setting them to black in the
`extra.css` so if we decide to add a color scheme later it will be easy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]