flyrain commented on a change in pull request #3287:
URL: https://github.com/apache/iceberg/pull/3287#discussion_r737825923
##########
File path:
spark/v3.2/spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java
##########
@@ -187,4 +202,45 @@ protected void withTableProperties(Map<String, String>
props, Action action) {
restoreProperties.commit();
}
}
+
+ protected void writePosDeletes(CharSequence path, long numRows, double
percentage) throws IOException {
+ OutputFileFactory fileFactory = newFileFactory();
+ SparkFileWriterFactory writerFactory =
SparkFileWriterFactory.builderFor(table())
+ .dataFileFormat(fileFormat())
+ .build();
+
+ ClusteredPositionDeleteWriter<InternalRow> writer = new
ClusteredPositionDeleteWriter<>(
+ writerFactory, fileFactory, table().io(),
+ fileFormat(), TARGET_FILE_SIZE_IN_BYTES);
+
+ PartitionSpec unpartitionedSpec = table().specs().get(0);
+ Set<Long> deletedPos = Sets.newHashSet();
+ while (deletedPos.size() < numRows * percentage) {
+ deletedPos.add(ThreadLocalRandom.current().nextLong(numRows));
Review comment:
yeah, it gets duplicates, that's why the loop is needed. It's not so
efficient in that sense. Although, it's not a big idea since it is a setup
phase in benchmark. I'm open to any idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
