chulucninh09 commented on issue #3283: URL: https://github.com/apache/iceberg/issues/3283#issuecomment-954145932
If we can make a PR to pandas, @fjetter idea about `engine='iceberg'` can be possible. Based on pandas source code, we need to check if `engine == 'iceberg'` then we return `IcebergImpl` class. https://github.com/pandas-dev/pandas/blob/66ce5de55b4aa6d4ca8bef65318cc9e2381689f6/pandas/io/parquet.py#L63-L68 In the class, we only need to implement constructor and `read` & `write` method. https://github.com/pandas-dev/pandas/blob/66ce5de55b4aa6d4ca8bef65318cc9e2381689f6/pandas/io/parquet.py#L250-L350 And also passing kwargs is possible, check these lines: https://github.com/pandas-dev/pandas/blob/66ce5de55b4aa6d4ca8bef65318cc9e2381689f6/pandas/core/frame.py#L2780-L2789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
