rdblue commented on a change in pull request #3407: URL: https://github.com/apache/iceberg/pull/3407#discussion_r738813141
########## File path: python/src/iceberg/partition_spec.py ########## @@ -0,0 +1,289 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from urllib import parse +from collections import defaultdict +from typing import List, Optional + +from iceberg.partition_field import PartitionField +from iceberg.schema import Schema +from iceberg.types import Type, NestedField +from iceberg.validation_exception import ValidationException + +PARTITION_DATA_ID_START = 1000 + + +class PartitionSpec(object): + fields_by_source_id: defaultdict[list] = None + field_list: List[PartitionField] = None Review comment: Can you help me understand the scope of these? Are the essentially instance variable declarations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
