rdblue commented on a change in pull request #2305:
URL: https://github.com/apache/iceberg/pull/2305#discussion_r739335609
##########
File path: flink-runtime/build.gradle
##########
@@ -42,6 +42,8 @@ project(':iceberg-flink-runtime') {
implementation(project(':iceberg-nessie')) {
exclude group: 'com.google.code.findbugs', module: 'jsr305'
}
+
+ implementation "org.apache.flink:flink-connector-base"
Review comment:
For other dependencies that we expect to be present at runtime, we use
compileOnly so the dependency doesn't leak into the runtime Jar. Is that
something we should do here as well? This looks like it would add the Flink Jar
into `runtimeClasspath`, which would get included in the Jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
