[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3400: Spark: Support dynamic partition filtering in 3.2

[GitBox]

aokolnychyi commented on a change in pull request #3400:
URL: https://github.com/apache/iceberg/pull/3400#discussion_r739436574



##########
File path: api/src/main/java/org/apache/iceberg/types/IndexByName.java
##########
@@ -166,9 +177,10 @@ public void afterMapValue(Types.NestedField valueField) {
   }
 
   private void addField(String name, int fieldId) {
-    String fullName = name;
+    String fullName = quote(name);
     if (!fieldNames.isEmpty()) {
-      fullName = DOT.join(DOT.join(fieldNames.descendingIterator()), name);
+      Iterator<String> quotedFieldNames = 
Iterators.transform(fieldNames.descendingIterator(), this::quote);
+      fullName = DOT.join(DOT.join(quotedFieldNames), quote(name));

Review comment:
       Fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org