rdblue commented on a change in pull request #3415:
URL: https://github.com/apache/iceberg/pull/3415#discussion_r739549871



##########
File path: .github/workflows/spark-ci.yml
##########
@@ -99,6 +99,33 @@ jobs:
         path: |
           **/build/testlogs
 
+  spark-31-tests:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        jvm: [8, 11]
+        spark: ['3.1']
+    env:
+      SPARK_LOCAL_IP: localhost
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-java@v1
+        with:
+          java-version: ${{ matrix.jvm }}
+      - uses: actions/cache@v2
+        with:
+          path: ~/.gradle/caches
+          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
+          restore-keys: ${{ runner.os }}-gradle
+      - run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | 
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
+      - run: ./gradlew -DsparkVersions=${{ matrix.spark }} -DhiveVersions= 
-DflinkVersions= :iceberg-spark:iceberg-spark-3.1:check 
:iceberg-spark:iceberg-spark-3.1-extensions:check 
:iceberg-spark:iceberg-spark-3.1-runtime:check -Pquick=true -x javadoc
+      - uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: test logs
+          path: |
+            **/build/testlogs

Review comment:
       Instead of adding another job here, can we update the `matrix.spark` 
parameter in the `spark-32-tests` config? One of the reasons to add `3.2` to 
the module names instead of some derivation like `32` was so that we could 
build the module names from `matrix.spark`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to