openinx commented on a change in pull request #2305:
URL: https://github.com/apache/iceberg/pull/2305#discussion_r740092461
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java
##########
@@ -40,4 +40,10 @@ private FlinkConfigOptions() {
.intType()
.defaultValue(100)
.withDescription("Sets max infer parallelism for source operator.");
+
+ public static final ConfigOption<Integer>
SOURCE_READER_FETCH_RECORD_BATCH_SIZE = ConfigOptions
+ .key("source.iceberg.reader.fetch-record-batch-size")
Review comment:
Yes, this is unrelated to the table/SQL execution. Both datastream job
and table SQL job are using the same configuration keys. So I'm okay to keep
the current name.
(In fact, if we don't consider the flink's configuration name, I'd prefer
to name it `iceberg.source.reader.fetch-record-batch-size`. But iceberg is also
a kind of flink connector, all the other flip-27 source connector has named it
as `source.<connector>.xxx`, so I think we can follow the naming).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
