rdblue commented on a change in pull request #3430:
URL: https://github.com/apache/iceberg/pull/3430#discussion_r740339607
##########
File path:
spark/v3.1/spark/src/test/java/org/apache/iceberg/spark/sql/TestDeleteFrom.java
##########
@@ -41,70 +38,6 @@ public void removeTables() {
sql("DROP TABLE IF EXISTS %s", tableName);
}
- @Test
- public void testDeleteFromUnpartitionedTable() {
- // This test fails in Spark 3.1. `canDeleteWhere` was added to
`SupportsDelete` in Spark 3.1,
- // but logic to rewrite the query if `canDeleteWhere` returns false was
left to be implemented
- // later.
- Assume.assumeTrue(Spark3VersionUtil.isSpark30());
Review comment:
I think Anton added new tests in place of these in 3.2. Can you check
whether they should be added here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
