kbendick commented on a change in pull request #3429:
URL: https://github.com/apache/iceberg/pull/3429#discussion_r740436862
##########
File path: core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java
##########
@@ -93,9 +100,22 @@ public OverwriteFiles caseSensitive(boolean
isCaseSensitive) {
}
@Override
- public OverwriteFiles validateNoConflictingAppends(Expression
newConflictDetectionFilter) {
+ public OverwriteFiles conflictDetectionFilter(Expression
newConflictDetectionFilter) {
Preconditions.checkArgument(newConflictDetectionFilter != null, "Conflict
detection filter cannot be null");
this.conflictDetectionFilter = newConflictDetectionFilter;
+ return this;
+ }
+
+ @Override
+ public OverwriteFiles validateNoConflictingData() {
+ this.validateNewDataFiles = true;
+ failMissingDeletePaths();
+ return this;
+ }
+
+ @Override
+ public OverwriteFiles validateNoConflictingDeletes() {
+ this.validateNewDeleteFiles = true;
failMissingDeletePaths();
Review comment:
Actually, this is the way both of these functions look in master - Is
this intentional?:
https://github.com/apache/iceberg/blob/fad77e8b4ee811f6bcbd1c440708e0bc5e1929c2/core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java#L100-L111
Wondering if this is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
