rdblue commented on a change in pull request #3240:
URL: https://github.com/apache/iceberg/pull/3240#discussion_r740621278
##########
File path: api/src/main/java/org/apache/iceberg/util/StructProjection.java
##########
@@ -155,6 +155,10 @@ public int size() {
@Override
public <T> T get(int pos, Class<T> javaClass) {
+ if (struct == null) {
+ return null;
Review comment:
I agree with the behavior here. Thanks for pointing to #2738.
In the future, I think it is better to fix bugs like this in separate PRs
that address a specific issue, like #2738. Having this mixed into a different
PR means we can't cleanly cherry-pick it and we lose information about when the
other issue was fixed. This is minor, but I think it really helps for
maintainability in the long run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
