szlta commented on a change in pull request #3242:
URL: https://github.com/apache/iceberg/pull/3242#discussion_r741171349
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java
##########
@@ -100,24 +102,47 @@
.toArray(InputSplit[]::new);
}
+ @VisibleForTesting
+ void checkHive3Present() {
Review comment:
As for a better solution to test this change I recommend adding a test
case in TestHiveIcebergStorageHandlerWithEngine. This case could have an assume
isVectorized=true, so it only runs for the vectorized configuration case. Here
we should create table with a complex type like, "create table test (a string,
b array<int>)", insert a row, and run a select query with a group by statement.
All this after setting
hive.vectorized.complex.types.enabled=false.
This test case should fail without your fix, but should pass with your fix,
so it'd be sufficient for verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
