aokolnychyi commented on a change in pull request #3420:
URL: https://github.com/apache/iceberg/pull/3420#discussion_r740476989
##########
File path: build.gradle
##########
@@ -489,8 +489,11 @@ project(':iceberg-arrow') {
implementation("org.apache.arrow:arrow-memory-netty") {
exclude group: 'com.google.code.findbugs', module: 'jsr305'
exclude group: 'io.netty', module: 'netty-common'
+ exclude group: 'io.netty', module: 'netty-buffer'
}
+ runtimeOnly("io.netty:netty-buffer")
Review comment:
Just for my understanding. We do need this dep for our Arrow
implementation at runtime.
Previously, it came from `arrow-memory-netty` and was shaded in the Spark
runtime jar. As far as I see, we kept the shading but also excluded
`netty-buffer` from the arrow dependency. What do we shade now?
##########
File path: build.gradle
##########
@@ -489,8 +489,11 @@ project(':iceberg-arrow') {
implementation("org.apache.arrow:arrow-memory-netty") {
exclude group: 'com.google.code.findbugs', module: 'jsr305'
exclude group: 'io.netty', module: 'netty-common'
+ exclude group: 'io.netty', module: 'netty-buffer'
}
+ runtimeOnly("io.netty:netty-buffer")
Review comment:
Are we trying to use `netty-buffer` from Spark?
##########
File path: build.gradle
##########
@@ -489,8 +489,11 @@ project(':iceberg-arrow') {
implementation("org.apache.arrow:arrow-memory-netty") {
exclude group: 'com.google.code.findbugs', module: 'jsr305'
exclude group: 'io.netty', module: 'netty-common'
+ exclude group: 'io.netty', module: 'netty-buffer'
}
+ runtimeOnly("io.netty:netty-buffer")
Review comment:
I did not see the update in `versions.props`. You mean we explicitly
define the version in `iceberg-arrow` now? As opposed to consuming whatever
`arrow-memory-netty` was bringing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
