wypoon edited a comment on pull request #3269:
URL: https://github.com/apache/iceberg/pull/3269#issuecomment-959803004


   I think adding a `Long` or `Optional<Long>` to the 
`org.apache.spark.sql.connector.catalog.Identifier` interface could work for us:
   ```
     static Identifier of(String[] namespace, String name, Long version) {
       return new IdentifierImpl(namespace, name, version);
     }
     ...
     Long version();
   ```
   Until the change to this interface makes it into a released Spark 3 version, 
we could add this extension to Iceberg and use this internal extension of 
`Identifier` to load the table with the snapshot id, when reading it using 
`.option("snapshot-id", ...)` or `.option("as-of-timestamp", ...)`. When a 
Spark version is released with this change to `Identifier`, we can switch from 
our internal extension to the upstream `Identifier`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to