kbendick edited a comment on pull request #3455: URL: https://github.com/apache/iceberg/pull/3455#issuecomment-959830183
> LGTM, nit , will just changing get() to getOrDefault(..., "0") be a bit less verbose? I initially thought that too. My one concern is that if there is an actual `null` stored in the map as the value for that key, we'll still get `null`. However, I added some tests that exercise Spark end to end and inspected the code. Using `getOrDefault` works so I've updated to that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
