rdblue commented on a change in pull request #3404: URL: https://github.com/apache/iceberg/pull/3404#discussion_r742088571
########## File path: aliyun/src/main/java/org/apache/iceberg/aliyun/oss/BaseOSSFile.java ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aliyun.oss; + +import com.aliyun.oss.OSS; +import com.aliyun.oss.OSSErrorCode; +import com.aliyun.oss.OSSException; +import com.aliyun.oss.model.SimplifiedObjectMeta; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; + +abstract class BaseOSSFile { + private final OSS client; + private final OSSURI uri; + private SimplifiedObjectMeta metadata; + + BaseOSSFile(OSS client, OSSURI uri) { + this.client = client; + this.uri = uri; + } + + public String location() { + return uri.location(); + } + + public OSS client() { + return client; + } + + public OSSURI uri() { + return uri; + } + + public boolean exists() { + try { + return getObjectMetadata() != null; + } catch (OSSException e) { + if (e.getErrorCode().equals(OSSErrorCode.NO_SUCH_BUCKET) || + e.getErrorCode().equals(OSSErrorCode.NO_SUCH_KEY)) { + return false; + } + throw e; + } + } + + protected SimplifiedObjectMeta getObjectMetadata() { Review comment: Please remove `get` from method names. It signals that there is either a more specific verb you should use (like "fetch" since this is hitting an external API) or that there is no need for it and it can simply be dropped. ########## File path: aliyun/src/main/java/org/apache/iceberg/aliyun/oss/BaseOSSFile.java ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aliyun.oss; + +import com.aliyun.oss.OSS; +import com.aliyun.oss.OSSErrorCode; +import com.aliyun.oss.OSSException; +import com.aliyun.oss.model.SimplifiedObjectMeta; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; + +abstract class BaseOSSFile { + private final OSS client; + private final OSSURI uri; + private SimplifiedObjectMeta metadata; + + BaseOSSFile(OSS client, OSSURI uri) { + this.client = client; + this.uri = uri; + } + + public String location() { + return uri.location(); + } + + public OSS client() { + return client; + } + + public OSSURI uri() { + return uri; + } + + public boolean exists() { + try { + return getObjectMetadata() != null; + } catch (OSSException e) { + if (e.getErrorCode().equals(OSSErrorCode.NO_SUCH_BUCKET) || + e.getErrorCode().equals(OSSErrorCode.NO_SUCH_KEY)) { + return false; + } + throw e; + } + } + + protected SimplifiedObjectMeta getObjectMetadata() { Review comment: Please remove `get` from method names. It signals that there is either a more specific verb you should use (like "fetch" since this is hitting an external API) or that there is no need for it and it can simply be dropped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
