kbendick commented on a change in pull request #3454:
URL: https://github.com/apache/iceberg/pull/3454#discussion_r742308856
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestNewRewriteDataFilesAction.java
##########
@@ -177,6 +187,59 @@ public void testBinPackWithFilter() {
assertEquals("Rows must match", expectedRecords, actualRecords);
}
+ @Test
+ public void testBinPackWithDeletes() throws Exception {
+ Table table = createTablePartitioned(4, 2);
Review comment:
Nit: Would it be worth while to add inline comments to explain these
parameters (like `createTablePartitioned(4 /* ??? */, 2 /* ??? */)`? Right now,
it's hard to tell immediately what these arguments are, but I'll leave the
choice to you.
##########
File path:
core/src/test/java/org/apache/iceberg/actions/TestBinPackStrategy.java
##########
@@ -33,6 +33,7 @@
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
+import org.assertj.core.util.Lists;
Review comment:
Question / Nit: Is there a reason to use `Lists` from `assertj` instead
of `Lists` from the relocated google commons library?
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestNewRewriteDataFilesAction.java
##########
@@ -177,6 +187,59 @@ public void testBinPackWithFilter() {
assertEquals("Rows must match", expectedRecords, actualRecords);
}
+ @Test
+ public void testBinPackWithDeletes() throws Exception {
+ Table table = createTablePartitioned(4, 2);
Review comment:
Nit: Would it be worth while to add inline comments to explain these
parameters (like `createTablePartitioned(4 /* ??? */, 2 /* ??? */)`? Right now,
it's hard to tell immediately what these arguments are, but I'll leave the
choice to you.
##########
File path:
core/src/test/java/org/apache/iceberg/actions/TestBinPackStrategy.java
##########
@@ -33,6 +33,7 @@
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
+import org.assertj.core.util.Lists;
Review comment:
Question / Nit: Is there a reason to use `Lists` from `assertj` instead
of `Lists` from the relocated google commons library?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
