kbendick commented on a change in pull request #3456:
URL: https://github.com/apache/iceberg/pull/3456#discussion_r742241890



##########
File path: 
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java
##########
@@ -169,6 +170,35 @@ public void 
testPartitionMetadataColumnWithUnknownTransforms() {
         () -> sql("SELECT _partition FROM %s", TABLE_NAME));
   }
 
+  @Test
+  public void testConflictingColumns() {
+    table.updateSchema()
+        .addColumn(MetadataColumns.SPEC_ID.name(), Types.IntegerType.get())
+        .addColumn(MetadataColumns.FILE_PATH.name(), Types.StringType.get())
+        .commit();

Review comment:
       Eventually, would it make sense to fail here, in the `updateSchema` 
pathway?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to