rdblue commented on a change in pull request #2305:
URL: https://github.com/apache/iceberg/pull/2305#discussion_r742093418
##########
File path: flink/build.gradle
##########
@@ -28,6 +28,7 @@ project(':iceberg-flink') {
implementation project(':iceberg-parquet')
implementation project(':iceberg-hive-metastore')
+ compileOnly "org.apache.flink:flink-connector-base"
Review comment:
@openinx, the tests run against the iceberg-flink module. They aren't
present in the 1.12 or 1.13 modules. If you want them to be run for those
modules, you'd need to add the source folder like you do for `src/main/java`.
If you choose to do that, let's also remove CI for the common module since we
don't need to run the tests outside of 1.12 and 1.13 if they are run in those
modules.
##########
File path: flink/build.gradle
##########
@@ -28,6 +28,7 @@ project(':iceberg-flink') {
implementation project(':iceberg-parquet')
implementation project(':iceberg-hive-metastore')
+ compileOnly "org.apache.flink:flink-connector-base"
Review comment:
@stevenzwu, I think that copying the parts that change is reasonable.
And once we remove support for 1.12, you can move the files back into the
common module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
