rymurr commented on a change in pull request #3029:
URL: https://github.com/apache/iceberg/pull/3029#discussion_r742811859
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedColumnIterator.java
##########
@@ -193,16 +193,6 @@ protected int nextBatchOf(
}
}
- public class FixedWidthTypeBinaryBatchReader extends BatchReader {
Review comment:
Maybe I am daft but it looks like you removed fixed width readers but I
don't see where you added any readers?
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -150,7 +150,7 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
vectorizedColumnIterator.varWidthTypeBatchReader().nextBatch(vec,
-1, nullabilityHolder);
break;
case FIXED_WIDTH_BINARY:
-
vectorizedColumnIterator.fixedWidthTypeBinaryBatchReader().nextBatch(vec,
typeWidth, nullabilityHolder);
Review comment:
So for clarification what is being added here? Fixed width or fixed
size? Or are they the same?
Can you clarify your comment on spark as well: fix width already was
(partially) handled and now its fully handled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
