rdblue edited a comment on pull request #3269: URL: https://github.com/apache/iceberg/pull/3269#issuecomment-961513673
@huaxingao, I agree with the direction to not add a version to Identifier. Adding a method to the catalog that can load different versions is a good idea. If we have two different `AS OF` clauses, I think that we should have two separate ways of passing the version so that we know whether `VERSION AS OF` or `TIMESTAMP AS OF` was used. I agree that VERSION should be passed as a string (hopefully an arbitrary one!) and TIMESTAMP as a long in micros from epoch, just like the other timestamps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
