jackye1995 commented on a change in pull request #3376:
URL: https://github.com/apache/iceberg/pull/3376#discussion_r743378261
##########
File path: build.gradle
##########
@@ -566,6 +566,23 @@ project(':iceberg-nessie') {
}
}
+project(':iceberg-dell') {
+ dependencies {
+ implementation project(':iceberg-core')
+ implementation project(':iceberg-common')
+ implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
+ implementation 'com.emc.ecs:object-client-bundle'
Review comment:
For Aliyun and AWS, we both followed the pattern that service
dependencies are expressed as `compileOnly`:
https://github.com/apache/iceberg/blob/master/build.gradle#L280.
This allows us to bundle all the Iceberg dependencies to a runtime jar for
Spark, Flink and Hive without any 3rd party dependencies, and if you need to
run EMC ECS, then you add you service jar in addition to the Iceberg runtime
jar in your own environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
